-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
range check 11 #356
range check 11 #356
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ohad-starkware)
stwo_cairo_prover/crates/prover/src/cairo_air/air.rs
line 67 at r1 (raw file):
pub memory_id_to_value: memory_id_to_big::Claim, pub verify_instruction: verify_instruction::Claim, pub range_check_11: range_check_11::Claim,
Add to mix_into, also for InteractionClaim
Code quote:
pub range_check_11
ea19a52
to
cc00de1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @shaharsamocha7)
stwo_cairo_prover/crates/prover/src/cairo_air/air.rs
line 67 at r1 (raw file):
Previously, shaharsamocha7 wrote…
Add to mix_into, also for InteractionClaim
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ohad-starkware)
cc00de1
to
73cb813
Compare
73cb813
to
55e1c23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ohad-starkware)
This change is